OstiumVault::lockDiscount() may revert due to division by 0

Low/InfoOstium audit·Three Sigma·RWA perpetuals DEX·19th February, 20243S-OS-L05

Description

OstiumVault::lockDiscount() reverts if maxDiscountThresholdP == uint16(100) * PRECISION_2, but the constructor and updateMaxDiscountThresholdP() allow setting it to this value.

Recommendation

Also check for equality by using <= instead of <.

Status

Addressed in #32af17a.

Source

Disclosed by 0xSimao · Sherlock's 2025 Watson of the Year · 21 first places in 57 audit contests